Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return 404 for non-existing revisions #6014

Merged
merged 5 commits into from
Jul 23, 2023
Merged

fix: return 404 for non-existing revisions #6014

merged 5 commits into from
Jul 23, 2023

Conversation

maybe-hello-world
Copy link
Collaborator

Links to non-existing revisions to docs should return 404
Closes #5934

@codecov
Copy link

codecov bot commented Jul 22, 2023 •
edited
Loading

Codecov Report

Merging #6014 (17fe4d5) into main (09f3477) will decrease coverage by 0.03%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #6014      +/-   ##
==========================================
- Coverage   88.67%   88.64%   -0.03%     
==========================================
  Files         288      288              
  Lines       40001    40010       +9     
==========================================
- Hits        35471    35467       -4     
- Misses       4530     4543      +13
Impacted Files Coverage Δ
ietf/doc/views_stats.py 74.80% <ø> (ø)
ietf/ietfauth/widgets.py 84.61% <ø> (ø)
ietf/nomcom/views.py 92.90% <33.33%> (-0.22%) ⬇️
ietf/doc/utils.py 87.15% <100.00%> (+0.01%) ⬆️
ietf/doc/views_doc.py 91.65% <100.00%> (+0.03%) ⬆️
ietf/doc/views_search.py 89.13% <100.00%> (+0.20%) ⬆️
ietf/nomcom/templatetags/nomcom_tags.py 70.83% <100.00%> (+3.64%) ⬆️
ietf/submit/forms.py 79.02% <100.00%> (+0.03%) ⬆️

... and 6 files with indirect coverage changes

jennifer-richards
jennifer-richards requested changes Jul 23, 2023
View reviewed changes
Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think one small addition is needed. See inline comment.

ietf/doc/views_doc.py Outdated Show resolved Hide resolved
@maybe-hello-world
Copy link
Collaborator Author

Feel free to squash before merging to simplify history if needed 😅

@jennifer-richards
Copy link
Member

Feel free to squash before merging to simplify history if needed 😅

:-) that's our usual practice, otherwise our history would be more, uh, "interesting."

jennifer-richards
jennifer-richards approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Your last change, I think, restores the behavior of returning the current bibtex for a request for a (non RFC) draft with a nonexistent revision. That seems fine to me.

@rjsparks rjsparks merged commit 4d61170 into ietf-tools:main Jul 23, 2023
@maybe-hello-world maybe-hello-world deleted the fix-5934 branch July 23, 2023 17:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jennifer-richards jennifer-richards jennifer-richards approved these changes

@rjsparks rjsparks rjsparks approved these changes

@larseggert larseggert Awaiting requested review from larseggert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc url parser accepts revision for rfcs
3 participants
@maybe-hello-world @jennifer-richards @rjsparks